Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] - Dynamic Option Provider #361

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[Improvement] - Dynamic Option Provider #361

merged 3 commits into from
Nov 21, 2024

Conversation

procnet0
Copy link
Contributor

Add context for Blocks/bricks/fieldcollection for select and multiselect option provider.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@procnet0
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@procnet0
Copy link
Contributor Author

recheck

@procnet0 procnet0 changed the title Improvement - Dynamic Option Provider [Improvement] - Dynamic Option Provider Nov 28, 2023
@procnet0
Copy link
Contributor Author

recheck

@procnet0 procnet0 marked this pull request as draft December 6, 2023 09:36
@procnet0 procnet0 marked this pull request as ready for review December 6, 2023 09:37
@robertSt7 robertSt7 closed this Jan 31, 2024
@robertSt7 robertSt7 reopened this Jan 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@robertSt7
Copy link
Contributor

@procnet0 Could you please replace var with let and const. Thank you

@mattamon
Copy link
Contributor

@procnet0 Could you please replace var with let and const. Thank you

@robertSt7 could you have a look again please. I changed it now to let

@pimcore pimcore unlocked this conversation Aug 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertSt7 robertSt7 added this to the 1.7.0 milestone Nov 21, 2024
@robertSt7 robertSt7 merged commit ecb4d67 into pimcore:1.x Nov 21, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@robertSt7
Copy link
Contributor

@procnet0 Thanks for the improvement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertSt7 robertSt7 robertSt7 left review comments

Assignees

@robertSt7 robertSt7

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@procnet0 @robertSt7 @mattamon @fashxp